London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Book Library by russom-g · Pull Request #562 · CodeYourFuture/Module-Data-Flows

russom-g · 2026-08-17T12:45:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Bug fixed. Dead code removed.

git status#

cjyuan

Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.

russom-g · 2026-08-18T09:04:26Z

Thanks for the feedback. Now a setup function is implemented. Both populateStorage and render function are wrapped inside the function.

cjyuan

Could you remove .vscode/settings.json and revert the changes made in .gitignore? Otherwise the validation bot will reject this PR.
Could you also check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

russom-g · 2026-08-21T19:56:53Z

Files that shouldn't be here are removed. I also have made some improvements following the requirement document. Thanks

cjyuan

Changes look good.

HTML code could use some more improvements. I will mark this PR as "Complete" first.

cjyuan · 2026-08-21T20:00:37Z

        <input
          type="number"
          class="form-control"
          id="pages"
          name="pages"
+          min="1"
          required
-        />
+        >


The browser checks the input elements against the specified constraints only when a user submits a form.
Without <form>, the browser won't check the input against the constraints such as required and min="1".

cjyuan · 2026-08-21T20:00:57Z

        <label class="form-check-label">
          <input
            type="checkbox"
            class="form-check-input"
            id="check"
-            value=""
-          />Read
+          >


This checkbox is not showing.

The issue is related to Bootstrap 4.4.1. Could you use AI to find a way to fix the issue? Mentioning "Bootstrap 4.4.1" might help.

cjyuan · 2026-08-21T20:03:11Z

-  this.author = author;
-  this.pages = pages;
-  this.check = check;
+  if (isNaN(pages) || pages <= 0) {


Could consider check if pages is a whole number instead.

cjyuan · 2026-08-21T20:05:43Z

note: You shouldn't have deleted the .gitignore that was in the original repo.

russom added 16 commits August 5, 2026 00:16

Parameter to the function updated with the object properties.

c36e8ee

Function created for displaying first and last name.

8bd864d

Comment added explaining what method is used.

b558fcc

pet !== null added to filter teachers with pets

4ae7b33

Function names updated.

abbcf09

Empty space deleted

828f30b

Log items logged with no formatting first

21524fb

Receipt heading QTY, ITEM and TOTAL created

5320ca4

Item price total and final total calculated

76b7b02

Formatting: add spaces to match the requirement

e0f84c2

Comments: remove irrelevant comments.

379c91a

Function names updated with meaningful names

eaedbd1

Formatting: add separating space between task 1 and 2 log print outs to

c98ec55

bug: add missing bracket on line 57

5bab8f7

fix bugs and refactor code

ce972dd

fix: update table row with index 1

062e71f

This comment has been minimized.

Sign in to view

russom added 3 commits August 17, 2026 13:53

Remove accidentally committed file

688c8ad

git status#

Remove accidentally committed file

2bf15a0

Remove destructuring exercise files

fe61651

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 17, 2026

This comment has been minimized.

Sign in to view

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 17, 2026

Restore Sprint-1/destructuring to match main

ab2fe0e

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 17, 2026

cjyuan reviewed Aug 17, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026

russom added 2 commits August 18, 2026 09:54

update: implement setup function

20a09c3

update: move myLibrary variable to the top

5de411e

update: remove empty space between codes

39fe2e1

cjyuan reviewed Aug 18, 2026

View reviewed changes

russom added 15 commits August 18, 2026 13:53

remove accidentally committed files

bff1d88

update: add html language attribute

d2087e5

update: add book library to title element

d22da54

update: check html with w3 validator

d7a80c1

update: check css code in w3c validator

aee7d44

change: replace let with const

eaf006d

update: improve variable naming

65c5495

refactor: update code to shorter version

6e5b655

update: improve function naming

dd6c87d

refactor: update code

b878045

refactor: update code

edef4b7

update: refactor code

12ae932

update: refactor code

3b68617

update: refactor code

db5e654

update: delete dead code

cec73a4

cjyuan reviewed Aug 21, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026

Navigation Menu

Uh oh!

Uh oh!

London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Book Library - #562

London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Book Library #562
russom-g wants to merge 40 commits into
CodeYourFuture:mainfrom
russom-g:feature/book-library

russom-g commented Aug 17, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Uh oh!

russom-g commented Aug 18, 2026

Uh oh!

cjyuan left a comment

Uh oh!

russom-g commented Aug 21, 2026

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Aug 21, 2026

Uh oh!

cjyuan Aug 21, 2026

Uh oh!

cjyuan Aug 21, 2026

Uh oh!

cjyuan commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

russom-g commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

russom-g commented Aug 18, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

russom-g commented Aug 21, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

russom-g commented Aug 17, 2026 •

edited

Loading