-
-
Notifications
You must be signed in to change notification settings - Fork 115
London | 25-ITP-May | Halimatou Saddiyaa | Sprint 2 | Book Library #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | 25-ITP-May | Halimatou Saddiyaa | Sprint 2 | Book Library #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work updating the book library.
I can see two areas where you might improve it further:
- Should you be able to add a book with a negative number of pages?
- When you delete a book, you get a popup after the delete happens. Is an
alert
after deletion the best user experience here?
…rt before deleting a book
Thanks for reviewing my PR @LonMcGregor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - you are done with this task now.
Learners, PR Template
Self checklist
Changelist
I’ve fixed the index.html and script.js files to ensure the Book Library page displays as expected.
Please review my PR
Questions
Ask any questions you have for your reviewer.