Skip to content

London | 25-ITP-May | Halimatou Saddiyaa | Sprint 2 | Book Library #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Halimatou-saddiyaa
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I’ve fixed the index.html and script.js files to ensure the Book Library page displays as expected.
Please review my PR

Questions

Ask any questions you have for your reviewer.

@Halimatou-saddiyaa Halimatou-saddiyaa added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2025
@Halimatou-saddiyaa Halimatou-saddiyaa changed the title London | 25-ITP-May | Halimatou Saddiyaa | Sprint 1 | Book Library London | 25-ITP-May | Halimatou Saddiyaa | Sprint 2 | Book Library Jul 29, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 6, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work updating the book library.

I can see two areas where you might improve it further:

  • Should you be able to add a book with a negative number of pages?
  • When you delete a book, you get a popup after the delete happens. Is an alert after deletion the best user experience here?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 6, 2025
@Halimatou-saddiyaa
Copy link
Author

Thanks for reviewing my PR @LonMcGregor
I've updated my code to prevent a user from adding a book with a negative number of pages.
I've also added an alert before book deletion, allowing the user to confirm or cancel the action.
Can you please check again those corrections?

@Halimatou-saddiyaa Halimatou-saddiyaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 6, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - you are done with this task now.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants