Skip to content

Glasgow | ITP-May-25 | Salah Ahmed | Data flows | Sprint 1 | Array Destructuring #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Glasgow | ITP-May-25 | Salah Ahmed | Data flows | Sprint 1 | Array Destructuring #251

wants to merge 5 commits into from
+53 −1

Conversation

avatarit
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I have implemented the 3 exercises

@avatarit avatarit added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Participant to add when requesting review labels Jul 28, 2025
@avatarit avatarit changed the title Glasgow | Salah Ahmed | Data flows | Sprint 1 | Glasgow | ITP-May-25 | Salah Ahmed | Data flows | Sprint 1 | Array Destructuring Jul 28, 2025
@avatarit avatarit mentioned this pull request Jul 29, 2025
Closed
1 task
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 30, 2025
LonMcGregor
LonMcGregor reviewed Jul 30, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on these tasks, salah. I think you could improve your answer to task 1 - I've left a comment there

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 30, 2025
@avatarit avatarit added the Needs Review Participant to add when requesting review label Jul 30, 2025
@LonMcGregor
Copy link

Perfect! You can close this PR now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review Needs Review Participant to add when requesting review labels Jul 30, 2025
@avatarit
Copy link
Author

avatarit commented Jul 30, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avatarit @LonMcGregor