London | ITP-May-2025 | Hibo Sharif | Module-Data-Group | Sprint2 | Book Library #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 28, 2025 12:10
-I added trim() to remove extra whitespaces in both ends when extra spaces added incorrectly to the form.
hibosharif202504
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Aug 3, 2025
cjyuan
added
Reviewed
added 2 commits
August 4, 2025 15:14
hibosharif202504
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2025
Comment on lines
30
to
48
| titleEl.value.trim() === "" || | ||
| authorEl.value.trim() === "" || | ||
| pagesEl.value.trim() === "" | ||
|
|
||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, author.value, pages.value, check.checked); | ||
| } | ||
| let pageCount = parseInt(pagesEl.value.trim()); | ||
| if (pageCount <= 0 || isNaN(pageCount)) { | ||
| alert("Please enter a valid page number"); | ||
| return false; | ||
| } | ||
| let book = new Book( | ||
| titleEl.value.trim(), | ||
| authorEl.value.trim(), | ||
| pageCount, | ||
| checkEl.checked | ||
| ); |
There was a problem hiding this comment.
For better performance (reduce number of function calls) and reducing the chance of using raw input accidently, we could stored the pre-processed/sanitized/normalized input in some variables first, and reference the variables in other part of the function.
const cleanTitle = title.value.trim();
...
const book = new Book(cleanTitle, cleanAuthor, pageCount, checkEl.checked);
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
-Ensured the table clears properly before re-rendering
Questions
Ask any questions you have for your reviewer.