WM | 25-ITP-May | Abdullah Saleh | Sprint 1 | Array Destructuring

[3bdullah-saleh]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[oluwatunmiisheii]

Minor suggestion here: the if check in the map is no longer needed; the filter already does two things

1. Filter out people who are not teachers
2. Filter out people who don't have pets.

.filter(({ occupation, pet }) => occupation === "Teacher" && pet)

[oluwatunmiisheii]

You could simplify this code by using Array.prototype.reduce instead of forEach with an external billTotal variable.

Reduce is designed to accumulate a value (like the total bill) while iterating over the array, which makes the intent of the code clearer and avoids mutating variables outside the loop.

For more details, you can check out the MDN docs here:
👉 MDN: Array.prototype.reduce

[oluwatunmiisheii]

minor suggestion here,

You can just do a console.log in the map

const GryffindorHouse = hogwarts
  .filter(({ house }) => house === "Gryffindor")
  .map(function ({ firstName, lastName }) {
    console.log(`${firstName} ${lastName}`)
  })

[oluwatunmiisheii]

You can just replace the return with a console.log here also

const hogwartsTeachers = hogwarts
  .filter(({ occupation, pet }) => occupation === "Teacher"  && pet)
  .map(function ({ firstName, lastName, pet }) {
    if (pet) {
      return `${firstName} ${lastName}`;
    }
  })
  .join("\n");