Skip to content

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
818db8c
Add files via upload
PawelBroilo Apr 21, 2025
66d2611
Test
PawelBroilo1985 Apr 23, 2025
ca17df7
Test
PawelBroilo1985 Apr 23, 2025
fc43ad7
Update index.html
PawelBroilo Apr 23, 2025
0a55d58
Update script.js
PawelBroilo Apr 23, 2025
2efaeff
Update index.html
PawelBroilo Apr 23, 2025
663d5f3
Update Book Library.html
PawelBroilo Apr 23, 2025
f2ca7b5
Update script.js
PawelBroilo Apr 23, 2025
f395310
Update Book Library.html
PawelBroilo Apr 23, 2025
c54024d
Update script.js
PawelBroilo Apr 23, 2025
2b015d1
Update Book Library.html
PawelBroilo Apr 23, 2025
13414c9
Update script.js
PawelBroilo Apr 23, 2025
57d732c
Update index.html
PawelBroilo Apr 23, 2025
aa16a36
Update Book Library.html
PawelBroilo Apr 23, 2025
82a7b01
Update Book Library.html
PawelBroilo Apr 23, 2025
4d22e09
Update Book Library.html
PawelBroilo Apr 23, 2025
008b991
Update script.js
PawelBroilo Apr 23, 2025
85ca2fa
Update Book Library.html
PawelBroilo Apr 23, 2025
080663d
Update script.js
PawelBroilo Apr 23, 2025
4048c4a
Update index.html
PawelBroilo Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions debugging/book-library/index.html
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why yo deleted the <script> tag in this file that imports the code from script.js?

You have a working implementation in Book Library.html. You can transfer the HTML code (only HTML code) from that file to this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't add a proper <script> tag to include your code from script.js, the app won't work properly.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<title>Book Library</title>
<meta
charset="utf-8"
name="viewport"
Expand Down Expand Up @@ -90,7 +90,5 @@ <h1>Library</h1>
</tr>
</tbody>
</table>

<script src="script.js"></script>
</body>
</html>
4 changes: 3 additions & 1 deletion debugging/book-library/script.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this script has bug and is not working properly. You will need to fix them.

Why don't you transfer your JS code from Book Library.html to this file?

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should only contain JavaScript code.

let myLibrary = [];

window.addEventListener("load", function (e) {
Expand Down Expand Up @@ -54,7 +55,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
Expand Down Expand Up @@ -101,3 +102,4 @@ function render() {
});
}
}
</script>