Skip to content

GLASGOW | DATA FLOWS | AIDA ZHUKOVA | BOOK LIBRARY #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+34 −32
Open

GLASGOW | DATA FLOWS | AIDA ZHUKOVA | BOOK LIBRARY #202

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
469c440
all bugs have been fixed
aidazhukova Apr 16, 2025
e3e0407
addressed Pr comments
aidazhukova Apr 17, 2025
e3cfc5f
changes validation
aidazhukova Apr 18, 2025
a82e70d
check if number is integer
aidazhukova Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions debugging/book-library/script.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lines 79, 97:

    • Are the values assigned to these id attributes unique?
    • Is there any need to assign an id attribute to either buttons?

  • Line 73:

    • With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as <i> can possibly ruin the display.

  • Can you think of a more consistent way to name the variables representing the two buttons, changeBut and delButton?

Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,16 @@ function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
pages.value == null ||
pages.value == "" ||
author.value == null ||
author.value == ""
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of input validation,

  1. Can .value be null? (Do we need to check someInputElement.value == null?)
  2. Do you accept books to appear in the app as shown in this pic:
    image

alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -53,8 +55,10 @@ function Book(title, author, pages, check) {
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
console.log(myLibrary)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for debugging/testing purpose, we should remove it from the "final product".


//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
Comment on lines +61 to 63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?

//insert updated row and cells
Expand All @@ -76,7 +80,7 @@ function render() {
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
Expand All @@ -90,11 +94,11 @@ function render() {

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = i + 5;
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down