Skip to content

Glasgow | Prati Amalden | Module Complexity | Sprint 1 | Analyse and Refactor in python#68

Open
PratiAmalden wants to merge 3 commits intoCodeYourFuture:mainfrom
PratiAmalden:sprint-1-python
Open

Glasgow | Prati Amalden | Module Complexity | Sprint 1 | Analyse and Refactor in python#68
PratiAmalden wants to merge 3 commits intoCodeYourFuture:mainfrom
PratiAmalden:sprint-1-python

Conversation

@PratiAmalden
Copy link
Copy Markdown

@PratiAmalden PratiAmalden commented Dec 12, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@PratiAmalden PratiAmalden added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 12, 2025
@PratiAmalden PratiAmalden changed the title Glasgow | Prati Amalden | Module Complexity | Sprint 1 | python Glasgow | Prati Amalden | Module Complexity | Sprint 1 | Analyse and Refactor in python Feb 24, 2026
@PratiAmalden PratiAmalden added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 24, 2026
cjyuan
cjyuan reviewed Mar 2, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026
cjyuan
cjyuan reviewed Mar 2, 2026
View reviewed changes
Sprint-1/Python/find_common_items/find_common_items.py Outdated
Comment on lines +24 to +27
for item in first_sequence:
if item in second_set and item not in seen:
seen.add(item)
common_items.append(item)
Copy link
Copy Markdown

@cjyuan cjyuan Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is correct.

Could consider taking advantage of built-in methods of a set -- less code and more efficient.
https://realpython.com/python-sets/

@PratiAmalden PratiAmalden added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 20, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PratiAmalden @cjyuan