London | 25-SDC-July | Ali Qassab | Sprint 2 | Implement a Skip List#50
Open
AliQassab wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-July | Ali Qassab | Sprint 2 | Implement a Skip List#50AliQassab wants to merge 2 commits intoCodeYourFuture:mainfrom
AliQassab wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
OracPrime
reviewed
Jan 26, 2026
| right = mid | ||
|
|
||
| # Insert at found position | ||
| self.data.insert(left, value) |
There was a problem hiding this comment.
Although you've found the insertion point in O(log(n)) this insert call is O(n), so your overall insert is O(n), which doesn't meet requirements
Author
There was a problem hiding this comment.
Fixed! Replaced the list-based implementation with a proper skip list using linked nodes and multiple levels. This achieves O(log n) insertion by updating pointers instead of using list.insert() which is O(n).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented simplified SkipList data structure:
Uses simple sorted list with binary search instead of complex multi-level structure for better maintainability.
Questions
Ready for review! All tests pass.