London | 25-SDC-July | Mikiyas Gebremichael | Sprint 2 | Improve code with precomputing #38
Conversation
Mikiyas-STP
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
5 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Mikiyas-STP
added
📅 Sprint 2
OracPrime
added
Review in progress
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
Prefix code is wrong.
Counting code works, but could be more efficient.
Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py
Outdated
Show resolved
Hide resolved
Sprint-2/improve_with_precomputing/count_letters/count_letters.py
Outdated
Show resolved
Hide resolved
OracPrime
added
Reviewed
Hi @OracPrime Thankyou for raising this things. i have resolved the issues now. please see the last two commits for my updates and let me know when this PR is ready to be closed. Thank you |
OracPrime
added
the
Complete
|
In theory when you make new changes you should remove Reviewed and add NeedsReview - helps it show up in the right places |
2 participants
Learners, PR Template
Self checklist
Changelist
Precomputing means doing calculations once in advance and reusing the results instead of repeating the same work.
It makes programs faster by trading extra memory for reduced computation time.
For example, counting all characters once and storing the results is faster than scanning the string repeatedly.
Questions
None