Skip to content

Conversation

@Andre601
Copy link
Collaborator

@Andre601 Andre601 commented Dec 2, 2024

Adds the ApplicationHandler class containing the handle method previously used in CmdApplication

This move was made to eventually remove the command in favour of the button-based approval/denial of applications.

I also decided to make the bot reply more vebose by listing the steps it currently goes through.
Tho, due to how the queue() method works (That being async) could the bot already be done before the messages are fully updated...
Only alternatives would be either logging in the console, or using the thread-blocking complete()

@gmitch215
Copy link
Member

Cool. I'll test this out soon.

@gmitch215
Copy link
Member

Had some issues with the RegEx.

Decided to just parse the markdown directly. Fields in Embeds are ordered, with 0 and 1 always being the user and repository fields respectively, so I cleaned up some things there.

You also forgot to close the bold text for the final success message.

@Andre601
Copy link
Collaborator Author

Andre601 commented Dec 2, 2024

I personally would still have checks to ensure the fields are user and repo respectively. Just in case there would be a random edge-case that could break this check...

@gmitch215
Copy link
Member

@Andre601 Wouldn't we deny them if they violate the usual URL rules (since it would be an invalid user & repo location)?

Will also implement edge case tests with #19.

@Andre601
Copy link
Collaborator Author

Andre601 commented Dec 3, 2024

I guess... So it's fine then.

@gmitch215 gmitch215 merged commit 94bd102 into master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants