Add modal to set reason for denying application. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll see if I can test this tomorrow. So far, looks good. |
Member
|
Seems that JDA makes modal fields required by default. Everything else works as intended. |
gmitch215
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Deny button open a modal where an optional reason can be set.
Not providing any will instead set
*No reason provided*Also fixes an oversight where
EmbedReplywould set non-ephemeral messages for button interactions, causing possible spam by people trying to use a button they have no perms for.Finally, some small improvements regarding username checks for submit modal to ensure the username is actually checked before sending it to the jenkins api (Removes IJ nagging about possibly-null issues)
Closes #17