Skip to content

chore(github): update windows runner #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oetr merged 3 commits into from
Jul 4, 2025
+31 −31
Merged

chore(github): update windows runner #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95561e2
fix(path traversal): sanitizers should not cause exceptions
oetr Jul 3, 2025
732046c
chore: remove push notifications to datadog
oetr Jul 3, 2025
771c10e
chore(pipelines): update windows runner
oetr Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/datadog.yaml
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion .github/workflows/prerelease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
name: linux
- os: macos-14
name: macos
- os: windows-2019
- os: windows-2022
name: windows

steps:
Expand All @@ -28,6 +28,12 @@ jobs:
distribution: zulu
java-version: 21

- name: Install Clang on Windows
if: matrix.os == 'windows-2022'
run: |
choco install llvm --version=19.1.0 --force
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append

- name: Append build settings to .bazelrc
shell: bash
run: |
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/run-all-tests-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ jobs:
name: Build & Test
strategy:
matrix:
os: [ macos-14, windows-2019 ]
os: [ macos-14, windows-2022 ]
# Test JDK 8 on Windows and mac only on main.
jdk: [8]
include:
- os: macos-14
arch: "macos-arm64"
bazel_args: "--xcode_version_config=//.github:host_xcodes"
- os: windows-2019
- os: windows-2022
arch: "windows"

steps:
Expand All @@ -55,6 +55,12 @@ jobs:
distribution: zulu
java-version: 21

- name: Install Clang on Windows
if: matrix.os == 'windows-2022'
run: |
choco install llvm --version=19.1.0 --force
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append

- name: Set Build Buddy config
run: .github/scripts/echoBuildBuddyConfig.sh ${{ secrets.BUILDBUDDY_API_KEY }} >> $GITHUB_ENV
shell: bash
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/run-all-tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
name: Build & Test
strategy:
matrix:
os: [ubuntu-22.04, windows-2019, macos-14]
os: [ubuntu-22.04, windows-2022, macos-14]
jdk: [21]
include:
- jdk: 21
Expand All @@ -32,7 +32,7 @@ jobs:
- os: macos-14
arch: "macos-arm64"
bazel_args: "--xcode_version_config=//.github:host_xcodes"
- os: windows-2019
- os: windows-2022
arch: "windows"

steps:
Expand All @@ -48,6 +48,12 @@ jobs:
run: .github/scripts/echoBuildBuddyConfig.sh ${{ secrets.BUILDBUDDY_API_KEY }} >> $GITHUB_ENV
shell: bash

- name: Install Clang on Windows
if: matrix.os == 'windows-2022'
run: |
choco install llvm --version=19.1.0 --force
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append

- name: Build & Test
run: bazelisk test ${{env.BUILD_BUDDY_CONFIG}} --java_runtime_version=remotejdk_${{ matrix.jdk }} ${{ matrix.bazel_args }} ${{ matrix.extra_bazel_args }} --build_tag_filters="-no-${{ matrix.arch }},-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" --test_tag_filters="-no-${{ matrix.arch }},-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" //...

Expand Down
9 changes: 8 additions & 1 deletion sanitizers/src/main/java/com/code_intelligence/jazzer/sanitizers/FilePathTraversal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,14 @@ private static void check(Path p) {
return;
}

if (p.toAbsolutePath().normalize().equals(ABSOLUTE_TARGET)) {
// catch all exceptions that might be thrown by the sanitizer
Path normalized;
try {
normalized = p.toAbsolutePath().normalize();
} catch (Throwable e) {
return;
}
if (normalized.equals(ABSOLUTE_TARGET)) {
Jazzer.reportFindingFromHook(new FuzzerSecurityIssueCritical("File path traversal: " + p));
}
}
Expand Down