feat: add hooks for Set.contains & Set.remove #1030
Merged
+160
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonresch
reviewed
Jan 6, 2026
Contributor
simonresch
left a comment
simonresch
left a comment
There was a problem hiding this comment.
Looks good!
What do you think about adding a test similar to https://github.com/CodeIntelligenceTesting/jazzer/blob/main/tests/src/test/java/com/example/MapFuzzer.java?
src/main/java/com/code_intelligence/jazzer/runtime/TraceCmpHooks.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/runtime/TraceCmpHooks.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/runtime/TraceCmpHooks.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR adds instrumentation hooks for Set.contains() and Set.remove() operations to improve fuzzing feedback by tracing comparisons with nearby elements when lookups fail.
Key Changes:
- Adds two new method hooks for
Set.containsandSet.removethat trigger when operations return false - Refactors existing map key lookup logic into a reusable
getLowerUpperBoundshelper method - Generalizes the
NavigableMapcheck (previouslyTreeMap) to support broader map implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/code_intelligence/jazzer/runtime/TraceCmpHooks.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/runtime/TraceCmpHooks.java
Outdated
Show resolved
Hide resolved
onionpsy
force-pushed
the
CIF-1887-set-mutator
branch
3 times, most recently
from
eddf0b7 to
720bfa2
Compare
onionpsy
force-pushed
the
CIF-1887-set-mutator
branch
from
720bfa2 to
1a83c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hooks for
Set.contains(...)andSet.remove(...)