Skip to content

Share Text Storage Delegates #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thecoolwinter
Copy link
Contributor

Description

Makes the text view share the MultiStorageDelegate if it's already installed on the text storage object. This allows for multiple editors to completely share a storage object, receiving update events and sending them to the necessary objects without removing the other text view's objects from the shared delegate.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@thecoolwinter thecoolwinter merged commit e35d655 into CodeEditApp:main Apr 25, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/shared-storage-delegates branch April 25, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants