Global Notification System#1984
Merged
austincondiff merged 21 commits intoCodeEditApp:mainfrom Mar 2, 2025
Merged
Conversation
… UI. Improved aesthetics of notification banner
…he notification overlay UI previously just used for temporary notifications.
thecoolwinter
requested changes
Feb 18, 2025
Collaborator
thecoolwinter
left a comment
There was a problem hiding this comment.
A few nitpicks and a suggestion for some duplicated initializers. Adding the FeatureIcon was a good idea! Documentation is also top notch.
CodeEdit/Features/InspectorArea/FileInspector/FileInspectorView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Notifications/Views/NotificationBannerView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Notifications/Views/NotificationOverlayView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Notifications/Views/NotificationOverlayView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Notifications/Views/NotificationOverlayView.swift
Outdated
Show resolved
Hide resolved
- Add system notification action button that, when clicked, focuses CodeEdit, runs the action, and dismisses the corresponding CodeEdit notification. - Dismissing a CodeEdit notification now also dismisses its corresponding system notification, and vice versa. - The notification panel in a workspace now closes when clicking outside of it, behaving like other menus. - Refactored notification state management: Moved display-related state from `NotificationService` to a dedicated view model to ensure notification panels remain independent across workspaces.
…ector can be enabled with a setting found in the hidden developer settings page.
…ification panel is presented. Removed notification tests and made the notification test in the dev inspector more configurable.
…nOverlay to notificationPanel. Fixed SwiftLint errors.
thecoolwinter
requested changes
Feb 20, 2025
Collaborator
thecoolwinter
left a comment
There was a problem hiding this comment.
One last question, and reopened a comment that I think was mistakenly resolved
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Oh whoops. I closed it not by mistake. I created the OverlayButtonStyle but didn't realize I left CloseButtobStyle there. I'll remove it. |
thecoolwinter
approved these changes
Mar 2, 2025
0xWDG
approved these changes
Mar 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a global notification system in CodeEdit that allows users to receive and manage notifications across all open workspaces. Notifications provide important alerts and updates while ensuring consistency across multiple instances of the application.
Note
To test, go to Settings, press F12. Go to the Developer page and toggle on "Show Internal Development Inspector". In a workspace, in the inspector, open the new internal development inspector by clicking the hammer icon.
Key Features
Temporary Notifications:
Sticky Notifications:
Notification Button & Popover:
Behavior:
Screenshots
Screen.Recording.2025-02-14.at.4.09.29.PM.mp4
Screen.Recording.2025-02-14.at.5.36.32.PM.mov
The following screen recording showcases the first iteration. In the design channel on Discord, @thecoolwinter suggested moving in this direction. While it required a bit more effort, I agree that it ultimately results in a much cleaner and more polished look.
Screen.Recording.2025-02-12.at.12.42.55.PM.mov
Usage
With a symbol (works with both SF Symbols and CodeEditSymbols)
The icon defaults to the users accent color if one isn't specified however you can specify a color here...
With a custom image...
With an emoji...
With text...
Future Considerations
Currently, NotificationManager is shared between workspaces. This is intentional because notifications should generally speaking be global and not workspace specific. We may at some point allow for workspace specific notifications in addition to global notifications.
Related Issues
Checklist