Clean Up File Management

[thecoolwinter]

Description

App changes:

• Creating a new file always selects it in the project navigator and selects or opens it in a tab.
• Creating a new folder always selects it.
• Renaming a file always selects it.
• Renaming a file no longer sometimes adds a trailing period to the file name.
• File system updates no longer clear the project navigator's selection.
• No longer attempts to save folders and files whose name was not changed when the name field is submitted.
• Fixes a case where the navigator filter was empty but files were still being filtered.

Code changes:

• Cleans up the file management API for the CEWorkspaceFileManager.
  • Each method now throws, and if it creates a file or folder it returns it.
  • Errors are logged by the file manager's own logger before being thrown, for better debugging output and standardization across the code base.
  • Introduced a FileManagerError enum that has meaningful error description and resolution messages. This type is now used in the file management methods where it makes sense. The type is suitable for presenting in an NSAlert.
• Standardizes up how the workspace is notified of new/moved/copied files. Changes include the project navigator and file inspector.
  • Always notifies the project navigator and other listeners using the workspace.listenerModel, as well as opening a tab if it's not a folder.
  • If file errors are thrown, presents an NSAlert with the error information.
• Removed a DispatchQueue.async call in the project navigator that caused a new selection received by the project navigator to be overwritten, causing a flashing selection when new files were created and subsequently selected, which also resulted in incorrect selections.
• Moved String.isValidFilename to its own file, and added checks for more invalid cases.
• Added a flag to the DirectoryEventStream to receive more timely notifications.
• Added a check to see if the project navigator filter is empty before displaying filtered files.

Tests:

• Added UI tests to the project navigator.
• Added unit tests for the isValidFilename extension.
• Added a UI testing document.
• Uncommented the directory changes listener test after adding the new flag to the directory event stream.

Related Issues

• Closes 🐞 Project Navigator does not show external updates to files and folders #1934
• Closes 🐞 File renamer appends . to .gitignore file #1966

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

On main

Screen.Recording.2025-01-15.at.1.46.06.PM.mov

Screen.Recording.2025-01-15.at.1.45.41.PM.mov

Screen.Recording.2025-01-15.at.1.43.06.PM.mov

Screen.Recording.2025-01-15.at.2.11.43.PM.mov

[Jeehut]

Looks good to me! 👍 🙏

[0xWDG]

Looks good!