Feature: IterMonitors for paginated monitors #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows iterating all the monitors, regardless of the getMonitors limit, which defaults to 50. IterMonitors is a Python generator. The API calls are done on demand, using Python yield. Thus preventing more calls than needed. Adds options 'offset' and 'limit' to getMonitors in order to implement the pagination.
getMonitorByName now works with more than 50 monitors, because it makes use of the pagination added in iterMonitors. getMonitorByName and getMonitorById now return the whole monitor information. Previously they returned just status and alltimeuptimeratio. They do so reusing getMonitors.
Ensure Uniform noJsonCallBack usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows iterating all the monitors, regardless of the getMonitors limit,
which defaults to 50.
IterMonitors is a Python generator. The API calls are done on demand,
using Python yield. Thus preventing more calls than needed.
Adds options 'offset' and 'limit' to getMonitors in order to implement
the pagination.