Skip to content

feat: merge the PR-comment browser + editor CTAs into one line#30

Merged
brovatten merged 2 commits into
mainfrom
feat/compact-cta-footer
Jun 13, 2026
Merged

feat: merge the PR-comment browser + editor CTAs into one line#30
brovatten merged 2 commits into
mainfrom
feat/compact-cta-footer

Conversation

@brovatten

Copy link
Copy Markdown
Member

Collapses the footer's two stacked call-to-action lines — a 🌐 Explore … in your browser → line and a separate See this … in your editor: Open in VS Code → line — into a single sentence: Explore this PR's architecture in your browser or VS Code. The browser link only joins when webview_ready (head analysis committed, non-fork PR), and "your" rides with the browser entry alone so it still reads correctly when only the editor link is present (… in VS Code); multiple detected editors render with an Oxford "or" (browser, VS Code, or Cursor), while the ⚠️ health banner and the proxy-only "Get the extension" line stay on their own lines.

Before / after:

- 🌐 Explore this PR's architecture in your browser →
-
- See this architecture in your editor: Open in VS Code →
+ Explore this PR's architecture in your browser or VS Code.

Testing: Rewrote tests/test_build_cta.py for the merged format and added cases for the join logic and each branch (browser+editor, editor-only, both editors, no-webview); full unit suite (123) green and black clean, and I rendered the real footer for the default, fork-PR, and proxy+both-editors cases.

🤖 Generated with Claude Code

Replace the two stacked CTA lines (a '🌐 Explore … in your browser →' line and a
separate 'See this … in your editor: Open in VS Code →' line) with a single
sentence: 'Explore this PR's architecture in your browser or VS Code.' The
browser link only joins when webview_ready (head analysis committed, non-fork
PR); 'your' rides with the browser entry alone so it still reads right when only
the editor link is present ('… in VS Code'). Multiple editors render with an
Oxford 'or' ('browser, VS Code, or Cursor'). The ⚠️ health banner and the
proxy-only 'Get the extension' line stay separate.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codeboarding-review

codeboarding-review Bot commented Jun 13, 2026

Copy link
Copy Markdown

Architecture review · 6 components changed

graph LR
    n_Action_Orchestrator["Action Orchestrator"]
    n_Structural_Analyzer_Documenter["Structural Analyzer #amp; Documenter"]
    n_Diffing_Visualization_Engine["Diffing #amp; Visualization Engine"]
    n_Integration_Feedback_Provider["Integration #amp; Feedback Provider"]
    n_Action_Orchestrator -- "triggers structural mapping and file rendering" --> n_Structural_Analyzer_Documenter
    n_Action_Orchestrator -- "initiates baseline comparison and mermaid gener…" --> n_Diffing_Visualization_Engine
    n_Structural_Analyzer_Documenter -- "provides filtered change sets and method metada…" --> n_Diffing_Visualization_Engine
    n_Diffing_Visualization_Engine -- "requests component naming and file-level filter…" --> n_Structural_Analyzer_Documenter
    n_Diffing_Visualization_Engine -- "provides visual syntax for report generation" --> n_Integration_Feedback_Provider
    n_Action_Orchestrator -- "delegates final CTA and webview link creation" --> n_Integration_Feedback_Provider
    n_Diffing_Visualization_Engine -- "Returns the updated analysis state to be saved…" --> n_Action_Orchestrator
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Integration_Feedback_Provider modified;
    linkStyle 1 stroke:#0b5d23,stroke-width:2px;
    linkStyle 0,2,3,4,5 stroke:#7d4e00,stroke-width:2px;
    linkStyle 6 stroke:#82071e,stroke-width:2px,stroke-dasharray:5 3;
Loading

Colors indicate component changes compared to main: 🟩 Added · 🟨 Modified · 🟥 Removed

Integration & Feedback Provider : 1 file changed
  • scripts/build_cta.py

Explore this PR’s architecture in your browser or VS Code.

codeboarding-action · run 27481078691

@brovatten brovatten merged commit 3168018 into main Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant