⚡ Bolt: batch config loading during bulk worktree creation#73
Conversation
Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
applyWorktreeCreateDefaultsinapps/agor-daemon/src/services/worktrees.tsto accept theAgorConfigas an argument instead of callingloadConfig()internally. Updated thecreatemethod to load the config once and pass it iteratively to each item during bulk insertions. Also updated the.jules/bolt.mdjournal.🎯 Why: When bulk creating worktrees,
loadConfig()was being awaited inside a.map()loop. BecauseloadConfig()reads and parses the YAML configuration file from disk on every invocation, this resulted in severe O(N) disk I/O performance bottlenecks proportional to the number of worktrees being created.📊 Impact: Reduces disk reads and parses from N to 1 during bulk worktree creations, significantly speeding up the endpoint and reducing CPU/IO usage.
🔬 Measurement: Create an array of 50-100 worktrees simultaneously via the REST or WS API. The response time will be noticeably faster since it drops 49-99 synchronous disk reads. Verified via passing test suite.
PR created automatically by Jules for task 8599988557426554309 started by @Donach