Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in id lookups#72

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-command-injection-3309621675663281814
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in id lookups#72
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-command-injection-3309621675663281814

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented Jun 3, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unsanitized user inputs (group names and usernames) were being string-interpolated directly into system commands executed using execSync. Since execSync evaluates commands within a shell (/bin/sh), attackers could inject arbitrary OS commands using shell metacharacters (e.g., ; rm -rf /).
🎯 Impact: Allowed unrestricted Arbitrary Command Execution on the host system as the Node.js process user.
πŸ”§ Fix: Replaced execSync with execFileSync across id-lookups.ts. This bypasses shell execution altogether. Furthermore, we implemented the -- double-dash operator before dynamic inputs (['group', '--', groupName]) to securely delimit the executable flags, neutralizing "argument injection" if inputs start with hyphens.
βœ… Verification: Unit tests for related functionality passing successfully. Lint and build verified.


PR created automatically by Jules for task 3309621675663281814 started by @Donach

…`execSync` with `execFileSync` to avoid spawning a shell during UID/GID lookups, and utilizes the `--` flag before dynamically supplied variables to treat them strictly as positional arguments, mitigating command and argument injection.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant