Skip to content

⚡ Bolt: [performance improvement] Batch configuration loads in worktree creations#71

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-batch-config-loads-717008145221759505
Open

⚡ Bolt: [performance improvement] Batch configuration loads in worktree creations#71
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-batch-config-loads-717008145221759505

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented Jun 3, 2026

💡 What

Modifies applyWorktreeCreateDefaults in WorktreesService to accept a single loaded config reference as an argument instead of calling loadConfig() internally, and hoists the configuration lookup to happen once per create() call.

🎯 Why

loadConfig() invokes synchronous file system reads (fs.readFileSync or parsing) each time it executes. Within WorktreesService.create(), mapping over multiple partial creation data inputs iteratively called applyWorktreeCreateDefaults(), leading to O(N) concurrent loadConfig() queries and disk I/O, which caused major performance bottlenecks when bootstrapping numerous components simultaneously.

📊 Impact

Eliminates O(N) disk I/O in the batch worktree creation path and reduces redundant config.yaml parses.

🔬 Measurement

Run pnpm --filter @agor/daemon test to observe unchanged correct outputs, with improved map mapping benchmarks.


PR created automatically by Jules for task 717008145221759505 started by @Donach

…ee creations

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant