⚡ Bolt: [performance improvement] Batch configuration loads in worktree creations#71
Conversation
…ee creations Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Modifies
applyWorktreeCreateDefaultsinWorktreesServiceto accept a single loadedconfigreference as an argument instead of callingloadConfig()internally, and hoists the configuration lookup to happen once percreate()call.🎯 Why
loadConfig()invokes synchronous file system reads (fs.readFileSyncor parsing) each time it executes. WithinWorktreesService.create(), mapping over multiple partial creationdatainputs iteratively calledapplyWorktreeCreateDefaults(), leading to O(N) concurrentloadConfig()queries and disk I/O, which caused major performance bottlenecks when bootstrapping numerous components simultaneously.📊 Impact
Eliminates O(N) disk I/O in the batch worktree creation path and reduces redundant
config.yamlparses.🔬 Measurement
Run
pnpm --filter @agor/daemon testto observe unchanged correct outputs, with improved map mapping benchmarks.PR created automatically by Jules for task 717008145221759505 started by @Donach