-
Notifications
You must be signed in to change notification settings - Fork 17
fix: building codspeed with clang #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: building codspeed with clang #137
Conversation
CodSpeed Performance ReportMerging #137 will degrade performances by 70%Comparing Summary
Benchmarks breakdown
|
e9e1f47
to
6c7b453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes compilation issues when building the codspeed crate with clang by addressing compiler-specific warnings and improving CI testing for different compilers.
- Adds compiler warning suppressions for C code generated from Zig
- Replaces specific tests with build-only validation for macOS and Windows
- Expands CI matrix to test both GCC and Clang compilers on Linux
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
crates/codspeed/build.rs | Adds warning suppression flags and uses clang-compatible flag handling |
.github/workflows/ci.yml | Updates CI matrix to test GCC/Clang separately and changes to build-only for unsupported platforms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
98dfc53
to
d76e6a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d76e6a1
to
817b416
Compare
1d90039
to
97933b1
Compare
97933b1
to
d08b3c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you add a check in the CI making sure the bindings generated are up to date?
As well maybe a small section explaining how to generate the bindings in the README/contributing?
Things I changed:
cargo-cross
tests