Skip to content

Conversation

xxhZs
Copy link

@xxhZs xxhZs commented Aug 6, 2023

Support build Insert with schema strings. And use query to support update and delete

@xxhZs xxhZs changed the title fix(delete,update): Support build Insert with schema strings. feat(delete,update): Support build Insert with schema strings. Aug 6, 2023
@xxhZs xxhZs changed the title feat(delete,update): Support build Insert with schema strings. feat(delete,update,insert): Support build Insert with schema strings. Aug 6, 2023
@slvrtrn
Copy link
Contributor

slvrtrn commented Sep 5, 2024

Adding "partial" insert support with a subset of fields makes sense, as it allows for certain use cases (EPHEMERAL columns, etc).
However, query builder (e.g., for ALTER TABLE statements) should not be part of this crate - it is an abstraction one level above the raw client.
CC @mshustov @serprex @loyd

@CLAassistant
Copy link

CLAassistant commented May 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ loyd
❌ BugenZhao
❌ xxhZs
You have signed the CLA already but the status is still pending? Let us recheck it.

@serprex
Copy link
Member

serprex commented May 26, 2025

your autoformat obfuscates the rest of the PR

@slvrtrn
Copy link
Contributor

slvrtrn commented Jun 9, 2025

Thanks for the contribution. Due to

autoformat obfuscates the rest of the PR

and failing tests, let's just close this one and extract the relevant bits into a separate PR.

@slvrtrn slvrtrn closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants