[jdbc-v2] Convert Clickhouse Array(T) to Java T[] instead of Object[]
#2627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've faced an issue when reading
Array(Decimal)with clickhouse-jdbc 0.9.2 and Spark 3.5.7 - instead of converting values to Spark'sDecimalType, it failed with exception:This is because
JdbcUtils.convert(value, java.math.BigDecimal.class, column)returnsObject[], and Java doesn't allow casts like those:Even if each item of array is actually a
BigDecimal.Now this method returns
BigDecimal[]for these arguments. This requires some reflection usage to constructT[]with T known only in runtime.I haven't run integration tests on this yet.
Checklist
Delete items not relevant to your PR:
Object[]#2457