Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error with the object creator #79360

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Jan 26, 2025

Summary

None

Purpose of change

The object creator project isn't building. An override was defined in #64046, but #78548 (both @akrieger) forgot to remove it for the object creator. Easy to do since we don't even build the project with CI anymore.

Describe the solution

Remove the override so it stops looking for something that isn't there.

Describe alternatives you've considered

Maybe it's time to just remove object creator from the repo? It hasn't worked in years, as far as anyone's mentioned, and it's sucking up developer time.

Since we're not even building it with CI this kind of breakage is only going to keep happening.

Testing

Project still does not build due to some indeterminable error with enum_traits template specialization. I troubleshooted it for a while but I couldn't even figure out where the bad template was. C++ compilers do not produce very helpful error messages.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 26, 2025
@akrieger
Copy link
Member

Who was trying to build it in the first place?

Maybe we should move it to out of repo and have it reference cdda as a submodule or something.

@RenechCDDA
Copy link
Member Author

RenechCDDA commented Jan 27, 2025

Who was trying to build it in the first place?

Maybe we should move it to out of repo and have it reference cdda as a submodule or something.

I was, because I wanted to see about making it do something useful. According to my message logs I was able to compile it in September 2022, and it didn't work then. I compiled again in February 2024, and it crashed on startup (not even producing a crash log until I cleverly guessed the directory where it 'expected' to be run from, moved it there, and only got a worthless crash log). This was my latest attempt and well, it's still not doing anything useful.

Honestly I think we should axe it entirely. I have never spoken to anyone who has even managed to use it.

Actually my 2024 experience was funny enough I have to share for posterity:
Not only did I have to guess the directory it expected to be run from (NOT the compile target directory!), but I also had to manually make a config folder for it. And then the crash log was unreadable due to symbolification

image

image

@akrieger
Copy link
Member

I would accept a PR to kill it.

@akrieger akrieger merged commit 3b5b2a4 into CleverRaven:master Jan 27, 2025
32 checks passed
@harakka
Copy link
Member

harakka commented Jan 27, 2025

FTR only reason I didn't remove it from the repo already was https://discord.com/channels/598523535169945603/598535827169083403/1251655741316796506, I don't think it belongs here either.

@RenechCDDA RenechCDDA deleted the object_creator_build_error branch January 27, 2025 06:07
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants