Ebooks: fix scanning and crafting menu info #79354
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crafting menu lacks "Written in:" info; Scanning should be allowed with backlight off. fixes CleverRaven#79301, fixes CleverRaven#79317
github-actions
bot
added
[JSON]
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Written in: ebook" crafting menu; Scanning should be allowed with backlight off.
fixes #79301, fixes #79317
Summary
Bugfixes "Fix written in: ebook; Allow scanning books with backlight off"
Purpose of change
There should be an option scan books with backlight off. It does not matter if the backlight on or off for taking photos on e-ink tablet. Because it's e-ink.
Written in: ebook should be present in crafting menu.
Describe the solution
Add EBOOKSAVE flag to e-ink tablet; Add ebooks to inventory::get_binned_items()
Describe alternatives you've considered
Testing
Manual testing: find non-memorized recipe in crafting menu. Scan e-book with screen off.
Additional context
#79317 is fixed. Not sure if it's by this PR or earlier.