Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] Raw cat/dog food can be used to tame dinosaurs #79351

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Mnkn10
Copy link
Contributor

@Mnkn10 Mnkn10 commented Jan 26, 2025

Summary

Mods "Allow using raw cat/dog food when taming dinosaurs."

Purpose of change

Raw cat and dog foods didn't work for taming dinosaur hatchlings. They probably should.

Describe the solution

Added DINOFOOD_B flag to raw cat food and DINOFOOD_A to raw dog food in the mod.

Describe alternatives you've considered

Not doing this.

Testing

  1. Load into a world with dinomod enabled
  2. Spawn or craft raw cat/dog foods
  3. Feed appropriate food to dinosaur hatchlings
  4. See that hatchlings were tamed
  5. Attempt to tame a dog/cat with appropriate food
  6. See that they were tamed

Additional context

Allow raw cat food and raw dog food to be used to tame dinos.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Food / Vitamins Comestibles and drinks Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) new contributor labels Jan 26, 2025
linting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 26, 2025
Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, right approach, items confirmed correct. Strong start!

@Maleclypse Maleclypse merged commit 1a49bb1 into CleverRaven:master Jan 27, 2025
28 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding new contributor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants