Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Island] Minor typo correction #79335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thaelina
Copy link
Contributor

Summary

Mods "Update a minor typo in the sky island progress display"

Purpose of change

Corrects a minor typo in the sky island progress display when asking the Island's Heart about your upgrade progress.

Describe the solution|

Change the of 5 to of 4 in Expedition Starts: <global_val:totalstarts> of 5

You can see in the line a couple above the typo that there are only 4 possible starts.

{ "math": [ "totalstarts = 1 + basementsunlocked + roofsunlocked + labsunlocked" ] },

I double checked the three variables and they're always 1 or 0.
image

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Sky Island Anything about the Sky Island mod labels Jan 25, 2025
@thaelina thaelina changed the title Update EOCs.json [Sky Island] Minor typo correction Jan 25, 2025
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant