Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: add v1 schema + versioning + tests #1407

Merged
merged 2 commits into from
Feb 4, 2024
Merged

other: add v1 schema + versioning + tests #1407

merged 2 commits into from
Feb 4, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 4, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review February 4, 2024 09:54
@ClementTsang ClementTsang force-pushed the schema_v1 branch 4 times, most recently from 0305fe4 to 59bd916 Compare February 4, 2024 11:22
@ClementTsang ClementTsang merged commit 0b92679 into main Feb 4, 2024
@ClementTsang ClementTsang deleted the schema_v1 branch February 4, 2024 11:26
@ClementTsang ClementTsang changed the title other: add v1 schema + versioning other: add v1 schema + versioning + tests Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant