Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Container customiztion and phantom slots & crafting grids #118

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brachy84
Copy link
Member

  • removes ContainerCustomizer
  • ability to easily use a custom Container by overriding UIFactory#createContainer or using UISettings#customContainer (the later takes priority)
  • canInteractWith function can now be customized by overriding UIFactory#canInteractWith or by using UISettings#canInteractWith (the later takes priority)
  • IGuiHolder#buildUI has now a third UISettings parameter
  • UISettings allows customizing the above two features and now holds the JEI settings. An instance is stored in ModularContainer and on client in ModularGuiContext
  • phantom slots have now their own widget and sync handler class
  • phantom slots still have an associated ModularSlots for convenience, but they are no longer added to Container#inventorySlots
  • use static vars for sync ids in ItemSlotSH and FluidSlotSyncHandler
  • change SlotGroupWidget#playerInventory() params to allow creating a player inventory without preset position
  • move ItemSlot and FluidSlot to com.cleanroommc.modularui.widgets.slot
  • create classes (CraftingModularContainer, InventoryCraftingWrapper and ModularCraftingSlot) to easly create crafting grids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant