fixed screenshot function. - #131
Merged
Merged
Conversation
Copilot started reviewing on behalf of
veronika-tseleva-cleantalk
September 8, 2026 13:59
View session
There was a problem hiding this comment.
🟡 Changes recommended
The dom-to-image error path now loses the underlying error details after debug logs were removed, making failures materially harder to diagnose.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adjusts the screenshot capture flow in FileUploader.makeScreenshot() by tightening the dom-to-image timeout and removing temporary debug logging, with corresponding rebuild output updates in the distributed bundles.
Changes:
- Reduced the dom-to-image render timeout from 15s to 10s.
- Removed several debug
console.log(...)statements from the dom-to-image screenshot path. - Propagated the same changes into the generated
dist/bundle outputs (minified and non-minified).
File summaries
| File | Description |
|---|---|
| js/src/fileuploader.js | Updates screenshot timeout and removes debug logs in the dom-to-image path. |
| dist/doboard-widget-bundle.js | Built bundle update reflecting the same screenshot-timeout/logging changes. |
| dist/doboard-widget-bundle.min.js | Minified built bundle update reflecting the same screenshot-timeout/logging changes. |
Review details
- Files reviewed: 1/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| console.log(7); | ||
| throw new Error('Screenshot failed due to CORS'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.