Skip to content

Commit

Permalink
Move lighthouse to a separate job.
Browse files Browse the repository at this point in the history
  • Loading branch information
grugnog committed Oct 20, 2023
1 parent 863fb10 commit fff6759
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# This file was auto-generated by the Firebase CLI
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on PR
name: Build and deploy to preview environment, run tests
'on': pull_request
jobs:
build_and_preview:
build_and_deploy:
if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
runs-on: ubuntu-latest
outputs:
urls: ${{ steps.urls.outputs.urls }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
Expand Down Expand Up @@ -48,11 +47,16 @@ jobs:
urls.push(`${{ steps.deploy.outputs.details_url }}${page}`);
});
core.setOutput('urls', urls.join('\n'));
lighthouse:
needs:
- build_and_deploy
runs-on: ubuntu-latest
steps:
- name: Lighthouse CI Action
id: lighthouse
uses: treosh/lighthouse-ci-action@v8
with:
temporaryPublicStorage: true
configPath: ./.lighthouserc.yml
urls: |
${{ steps.urls.outputs.urls }}
${{ steps.urls.outputs.urls }}

0 comments on commit fff6759

Please sign in to comment.