Revamping the verilog code editor - 01 #628
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
""" WalkthroughThe changes enhance the Verilog code editor by enabling bracket matching in the CodeMirror setup and updating the editor's CSS for improved spacing, font, and appearance. No changes were made to exported or public entity declarations, and the modifications are limited to editor configuration and styling. Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/styles/css/main.stylesheet.css (1)
1740-1743: Embed the JetBrains Mono font locally (withfont-display: swap).
font-family: 'JetBrains Mono', monospaceassumes the font is already available on the user’s machine. If it isn’t, the browser will silently fall back to the system monospace, defeating the purpose of the change.Consider adding:
@font-face { font-family: 'JetBrains Mono'; src: url('/assets/fonts/JetBrainsMono-Regular.woff2') format('woff2'); font-weight: 400; font-style: normal; font-display: swap; }Placing the font in the repository (or loading via a trusted CDN) ensures visual consistency and avoids FOUT/FOIT issues.
src/simulator/src/Verilog2CV.js (1)
284-294: Minor: bind extra key for quick bracket jump?Since
matchBracketsis now active, you might expose CodeMirror’s built-in jumpToBracket (Ctrl-Mby default) for power users:-extraKeys: { 'Ctrl-Space': 'autocomplete' }, +extraKeys: { + 'Ctrl-Space': 'autocomplete', + 'Ctrl-M': 'jumpToBracket' +},Purely optional, but complements the new feature.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/simulator/src/Verilog2CV.js(2 hunks)src/styles/css/main.stylesheet.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - circuitverse
- GitHub Check: Header rules - circuitverse
- GitHub Check: Pages changed - circuitverse
🔇 Additional comments (1)
src/simulator/src/Verilog2CV.js (1)
29-31: Nice – bracket matching enabled.The addon import and
matchBrackets: trueoption are correct and coexist safely withautoCloseBrackets. No further action needed.
Fixes #562
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit
New Features
Style