-
Notifications
You must be signed in to change notification settings - Fork 156
Feat shift register #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gsoc25-open-hardware-component-library
Are you sure you want to change the base?
Feat shift register #624
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nihal4777 can in SISO or SIPO can we remove writing the inp1..inp2 etc or so on, similarly for the output so that end-user can get better UX
also on click on the register it won't have that yellow color that is in other components, please add that feature alos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also make the user know 0 = shift and 1 = load
input in shift register can be of 1 bit only right? if we want multiple bits then there should be multiple shift regsters (which can make stack on the top of each other as in Logisim) also I think that multibit feature is not working , can you please check and also if it is working can you please send a screen recording |
added in tooltip |
For bitwidth: 20250801_074916.mp4 |
|
||
this.width = 60; | ||
|
||
this.noOfStages = noOfStages || parseInt(prompt('Enter number of stages:')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aryanndwi123 Does prompt work in tauri ?
Fixes #567
Describe the changes you have made in this PR
Added Shift Register Component
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.