Skip to content

BUG : Fix misalignment of zoom slider circle in toolbar and made it acc to req ui #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blazethunderstorm
Copy link

@blazethunderstorm blazethunderstorm commented Jun 15, 2025

Fixes #603

Describe the changes you have made in this PR -

Fixed the alignment issue of the zoom slider thumb within the quick action toolbar. The circle (thumb) was previously slightly misaligned vertically on both desktop and mobile views. Updated the CSS styles for ::-webkit-slider-thumb and ::-moz-range-thumb to ensure proper centering across browsers and screen sizes. This improves the visual consistency and polish of the zoom control component.

Screenshots of the changes (If any) -

Before ---

image

After ---

image

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • Style
    • Updated the zoom slider and buttons for a modern, consistent look with improved alignment and refined styling.
    • Enhanced slider visuals with smoother hover effects and clearer focus states.
    • Redesigned the mobile quick button bar to a compact, absolute-positioned layout with consistent icon sizes and added drag support.
    • Simplified component structure by removing unused elements and streamlining button containers.

cc @ThatDeparted2061 @Arnabdaz @niladrix719

Copy link

netlify bot commented Jun 15, 2025

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 7868c6a
🔍 Latest deploy log https://app.netlify.com/projects/circuitverse/deploys/6853f5ec04866f00082c1e3b
😎 Deploy Preview https://deploy-preview-604--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46 (🔴 down 1 from production)
Accessibility: 72 (no change from production)
Best Practices: 92 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 15, 2025

"""

Walkthrough

The CSS for the zoom slider in QuickButton.vue was comprehensively updated. The changes include adjustments to font size, layout, button styling, and especially the slider track and thumb alignment and appearance, targeting both Firefox and WebKit browsers. No modifications were made to the component's template or script logic.

The QuickButtonMobile.vue component was restructured by removing nested containers and unused elements, adding a draggable panel, and replacing scoped styles with global styles that define an absolute-positioned horizontal quick button bar with consistent icon sizes and improved slider styling. A new dragover event handler was added.

Changes

File(s) Change Summary
src/components/Navbar/QuickButton/QuickButton.vue Overhauled CSS for the zoom slider: font size, flex layout, unified button style, improved slider track and thumb alignment, updated browser-specific styles, and refined focus/hover effects.
src/components/Navbar/QuickButton/QuickButtonMobile.vue Restructured template removing nested containers and unused components; added draggable panel with drag-dot SVG; replaced scoped styles with global styles for absolute-positioned quick button bar; added dragover event handler; simplified button icon styling and removed timing and hamburger buttons.

Assessment against linked issues

Objective Addressed Explanation
Correct misalignment of the zoom slider circle in the toolbar (#603)
Ensure the zoom slider thumb is centered and visually aligned within the track (#603)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Restructuring and styling of QuickButtonMobile.vue including draggable panel and removal of timing/hamburger buttons (src/components/Navbar/QuickButton/QuickButtonMobile.vue) These changes are unrelated to the zoom slider alignment issue described in #603.
Addition of dragover event handler in QuickButtonMobile.vue (src/components/Navbar/QuickButton/QuickButtonMobile.vue) Drag event handling is unrelated to the zoom slider misalignment issue in #603.
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-19T11_36_17_190Z-debug-0.log


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@blazethunderstorm
Copy link
Author

@ThatDeparted2061 pls review the pr , thanks

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (3)
src/components/Navbar/QuickButton/QuickButton.vue (3)

215-232: Add Keyboard Focus Indicators
The decrement/increment buttons lack a visible focus style for keyboard users. Introduce a :focus-visible rule (e.g., outline or box-shadow) to ensure accessibility.


252-260: Consider Hover State for Thumb
The 12×12 px thumb with box-shadow is well-styled. You may want to add a ::-moz-range-thumb:hover rule for additional hover feedback.


281-292: Use Transform for Vertical Centering
Hardcoded margin-top: -5px may break if track height changes. Prefer position: relative; top: 50%; transform: translateY(-50%); for more resilient centering.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d8ca00 and 9cb241b.

📒 Files selected for processing (1)
  • src/components/Navbar/QuickButton/QuickButton.vue (2 hunks)
🔇 Additional comments (5)
src/components/Navbar/QuickButton/QuickButton.vue (5)

206-213: CSS Adjustment Approved
The revised .zoom-slider flex layout, reduced font size, and alignment properties correctly center the slider controls and match the design spec.


234-237: Hover State Enhancement Confirmed
The opacity transition on hover provides clear feedback without affecting layout.


245-250: Firefox Track Styling OK
The translucent 2 px track in Firefox matches the WebKit version and aligns with the UI requirements.


262-264: Verify Focus Visibility
The focus style removes the outline but relies on a subtle box-shadow. Confirm that this meets your accessibility contrast requirements.


274-279: WebKit Track Styling Matches
The 2 px white track in WebKit browsers is consistent with Firefox and aligns with the design.

@ThatDeparted2061
Copy link
Member

@blazethunderstorm check the changes for small screen and address the coderabbit suggestions. Then I'll approve it

@blazethunderstorm
Copy link
Author

@ThatDeparted2061 i have made req changes

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/components/Navbar/QuickButton/QuickButtonMobile.vue (1)

69-69: Nitpick: Inline styles should be moved to CSS classes.

Consider moving the inline style to a CSS class for better maintainability.

-              <i style="color: #ddd" class="fas fa-expand-arrows-alt"></i>
+              <i class="fas fa-expand-arrows-alt view-icon"></i>

Add corresponding CSS:

.view-icon {
    color: #ddd;
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cb241b and 7868c6a.

📒 Files selected for processing (2)
  • src/components/Navbar/QuickButton/QuickButton.vue (2 hunks)
  • src/components/Navbar/QuickButton/QuickButtonMobile.vue (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/Navbar/QuickButton/QuickButton.vue
🔇 Additional comments (9)
src/components/Navbar/QuickButton/QuickButtonMobile.vue (9)

2-5: LGTM: Clean template restructuring with drag support.

The template has been well-restructured with a single container and proper drag functionality. The drag panel implementation looks correct.


72-84: LGTM: Zoom slider structure maintained.

The zoom slider HTML structure is preserved correctly with proper input attributes and button controls.


92-98: LGTM: Proper drag event handling.

The dragover function correctly resets the styling when drag events occur. The implementation is clean and follows good practices.


245-254: Excellent: Proper Firefox zoom slider thumb alignment fix.

The Mozilla range thumb styling correctly addresses the misalignment issue mentioned in the PR. The 12px width/height with border-radius: 50% creates a perfectly circular thumb, and the styling ensures proper visual consistency.


273-284: Excellent: WebKit zoom slider thumb alignment fix addresses the core issue.

The key fix is on line 281 with margin-top: -5px which properly centers the 12px circular thumb on the 2px track. This directly addresses the misalignment issue mentioned in the PR objectives.

The calculation is correct: (12px thumb height - 2px track height) / 2 = 5px offset needed.


238-243: LGTM: Consistent track styling for Firefox.

The Mozilla range track styling with 2px height and proper background color ensures visual consistency with the WebKit implementation.


266-271: LGTM: WebKit track styling matches Firefox implementation.

The webkit slider track with 2px height matches the Mozilla implementation, ensuring cross-browser consistency.


290-347: LGTM: Responsive design for smaller screens.

The media query properly scales button sizes for screens under 991px width, ensuring good mobile experience.


101-101: ```shell
#!/bin/bash

Extract the <style> block from QuickButtonMobile.vue to list its defined CSS classes

sed -n '1,200p' src/components/Navbar/QuickButton/QuickButtonMobile.vue | sed -n '/<style/,/</style>/p'


</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

Comment on lines +115 to 124
.quick-btn {
display: flex;
align-items: center;
z-index: 99;
justify-content: space-between;
padding: 0 1.5rem;
position: absolute;
width: 400px;
height: 33px;
top: 90px;
right: 280px;
border-radius: 7px;
z-index: 100;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Review absolute positioning values for responsiveness.

The fixed positioning values (width: 400px, top: 90px, right: 280px) might not work well across all mobile screen sizes. Consider using responsive units or media queries.

.quick-btn {
  display: flex;
  position: absolute;
-  width: 400px;
+  width: min(400px, calc(100vw - 40px));
  height: 33px;
-  top: 90px;
-  right: 280px;
+  top: 5rem;
+  right: min(280px, 5vw);
  border-radius: 7px;
  z-index: 100;
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.quick-btn {
display: flex;
align-items: center;
z-index: 99;
justify-content: space-between;
padding: 0 1.5rem;
position: absolute;
width: 400px;
height: 33px;
top: 90px;
right: 280px;
border-radius: 7px;
z-index: 100;
}
.quick-btn {
display: flex;
position: absolute;
width: min(400px, calc(100vw - 40px));
height: 33px;
top: 5rem;
right: min(280px, 5vw);
border-radius: 7px;
z-index: 100;
}
🤖 Prompt for AI Agents
In src/components/Navbar/QuickButton/QuickButtonMobile.vue around lines 115 to
124, the CSS uses fixed pixel values for width, top, and right properties which
can cause layout issues on different mobile screen sizes. Replace these fixed
pixel values with responsive units like percentages, vw, or use media queries to
adjust the positioning and size based on screen width to ensure the button
displays correctly on all devices.

@blazethunderstorm
Copy link
Author

@ThatDeparted2061 pls review

@ThatDeparted2061
Copy link
Member

ThatDeparted2061 commented Jul 1, 2025

Where did you see this slider issue, i dont see it in tauri and web simulator ?

@blazethunderstorm
Copy link
Author

@ThatDeparted2061 in web simulator

@blazethunderstorm
Copy link
Author

Its there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug: Misaligned Zoom Slider in Toolbar
2 participants