Fix: Change imports from partial v0/src and src to to complete v0/src #523
Conversation
WalkthroughThis pull request updates several configuration files and CSS imports. In Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ThatDeparted2061
changed the title
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
v1/src/components/Navbar/Navbar.css (1)
20-20: Verify Logo Asset URL Consistency
The logo background is still referenced asurl(/src/assets/logo.svg). Please confirm if this is intentional. If shared assets are meant to be version‑specific, consider updating this path (e.g. to/v1/src/assets/logo.svg) for consistency.v0/src/components/Navbar/Navbar.css (1)
20-20: Review Asset URL for Logo Background
The logo’s background URL remains asurl(/src/assets/logo.svg). Given the objective to remove partial references and use complete paths (e.g.v0/src), please verify whether this asset path should be updated to something like/v0/src/assets/logo.svgfor consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src-tauri/tauri.conf.json(1 hunks)tsconfig.json(2 hunks)v0/src/components/Navbar/Navbar.css(1 hunks)v1/src/components/Navbar/Navbar.css(1 hunks)
🔇 Additional comments (5)
v1/src/components/Navbar/Navbar.css (1)
1-1: Color Theme Import Updated
The import statement now correctly points to/v1/src/styles/color_theme.scss, which aligns with the new version-specific directory structure.src-tauri/tauri.conf.json (1)
19-20: Enable Devtools in Tauri Configuration
The addition of"devtools": truealongside"fullscreen": falsenow enables Tauri devtools, which is useful for debugging. Ensure that this setting is controlled (or conditionally disabled) in production environments to avoid potential security risks.v0/src/components/Navbar/Navbar.css (1)
1-1: Color Theme Import Path Correction
The updated import now references/v0/src/styles/color_theme.scss, which matches the new directory structure for v0. This change is consistent with the project’s reorganization.tsconfig.json (2)
16-19: Updated Path Mappings in tsconfig.json
Thepathsconfiguration now maps#/*to./v0/src/*and@/*to./v0/src/components/*as intended. This update correctly reflects the new directory structure.
27-31: Updated Include Array
Theincludearray now covers the new directory structure (v0/src/**/*), which will ensure that TypeScript picks up the correct files.
|
@niladrix719 PTAL |
Earlier we had circuit logic imports from v0/src and front end imports from src which were causing ambiguitites in the desktop application and creating room for errors in the vue-simulator.
For example :
TypeScript thinks @/MyComponent is in ./src/components/, but at runtime, Vite tries to load it from ./v0/src/components/, causing:
- Module Not Found errors (Cannot find module)
- Inconsistent build/runtime behavior
- VSCode and ESLint auto-imports pointing to wrong locations
I have also enabled devtools in tauri to help enable better issue probing.
cc @niladrix719 @vedant-jain03
Summary by CodeRabbit
New Features
Chores