Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: converted all DOM manipulations to Vue's reactive system in SaveImage.vue #291

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

niladrix719
Copy link
Member

Proof of Work GSoC'24

Describe the changes you have made in this PR -

  • removed all JQuery DOM manipulations with Vue's reactive System
  • Added standard typescript type annotations

Screenshots of the changes (If any) -

Screen.Recording.2024-03-24.at.1.24.08.PM.mov

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit d2d676e
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/65ffdcd295d53d00082f80e5
😎 Deploy Preview https://deploy-preview-291--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 9a087f4
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/65ffdce4da8f24000847e17a
😎 Deploy Preview https://deploy-preview-291--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
nice work @niladrix719

@Arnabdaz Arnabdaz merged commit 2c02d92 into CircuitVerse:main Mar 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants