Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Circuit Elements Panel Bug Hiding Lower Section #286

Merged

Conversation

itsHamdySalem
Copy link
Contributor

Fixes #285

Describe the changes you have made in this PR -

Adjusted the styling of the panel body in the ElementsPanel component to enable vertical scrolling. This ensures that the panel remains fully accessible even when expanded elements exceed the viewport height.

Screenshots of the changes (If any) -

  • before the changes:
CircuitVerse.-.Google.Chrome.2024-03-16.17-03-52.mp4
  • after the changes:
CircuitVerse.-.Google.Chrome.2024-03-16.17-37-25.mp4

Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 32394b7
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/6600f6917b7836000805a9f0
😎 Deploy Preview https://deploy-preview-286--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solution would make it confusing for users and also the user experience would degrade.
I would suggest you to take a approach like the main simulator where we decreased the height of the sections you can see the main simulator for more info.

@itsHamdySalem
Copy link
Contributor Author

this solution would make it confusing for users and also the user experience would degrade. I would suggest you to take a approach like the main simulator where we decreased the height of the sections you can see the main simulator for more info.

Thank you for your feedback. I understand your concerns about the proposed solution potentially confusing users and degrading the user experience.

Regarding your suggestion to decrease the height of the sections, while it was implemented, it didn't fully resolve the issue. Expanding any section when the panel is moved down still poses a problem.

I propose an alternative solution: instead of hiding the scrollbar, we could style it to make it visible. This would maintain clarity for users while ensuring a smooth user experience.

I'd appreciate your input on which approach to proceed with.

Once again, I appreciate your thorough review and suggestions.

@itsHamdySalem itsHamdySalem requested a review from Arnabdaz March 19, 2024 22:31
@Arnabdaz
Copy link
Member

@itsHamdySalem I would recommend you going with the solution as in the current simulator we can brainstorm on some better solution later but let's not add scrolling into the panels for now.

@itsHamdySalem
Copy link
Contributor Author

@Arnabdaz Thank you for your feedback. I've already proceeded with your suggestion and pushed the changes. Please check the deploy preview for verification.

@Arnabdaz Arnabdaz merged commit 8fa90f7 into CircuitVerse:main Mar 25, 2024
9 checks passed
@Arnabdaz
Copy link
Member

nice work @itsHamdySalem
you can join out slack channels for discussions about how to improve the panels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug: UI] Circuit Elements Panel: Expanded Elements Hide Lower Section
2 participants