-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Circuit Elements Panel Bug Hiding Lower Section #286
Fix: Circuit Elements Panel Bug Hiding Lower Section #286
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this solution would make it confusing for users and also the user experience would degrade.
I would suggest you to take a approach like the main simulator where we decreased the height of the sections you can see the main simulator for more info.
Thank you for your feedback. I understand your concerns about the proposed solution potentially confusing users and degrading the user experience. Regarding your suggestion to decrease the height of the sections, while it was implemented, it didn't fully resolve the issue. Expanding any section when the panel is moved down still poses a problem. I propose an alternative solution: instead of hiding the scrollbar, we could style it to make it visible. This would maintain clarity for users while ensuring a smooth user experience. I'd appreciate your input on which approach to proceed with. Once again, I appreciate your thorough review and suggestions. |
@itsHamdySalem I would recommend you going with the solution as in the current simulator we can brainstorm on some better solution later but let's not add scrolling into the panels for now. |
@Arnabdaz Thank you for your feedback. I've already proceeded with your suggestion and pushed the changes. Please check the deploy preview for verification. |
nice work @itsHamdySalem |
Fixes #285
Describe the changes you have made in this PR -
Adjusted the styling of the panel body in the
ElementsPanel
component to enable vertical scrolling. This ensures that the panel remains fully accessible even when expanded elements exceed the viewport height.Screenshots of the changes (If any) -
CircuitVerse.-.Google.Chrome.2024-03-16.17-03-52.mp4
CircuitVerse.-.Google.Chrome.2024-03-16.17-37-25.mp4