-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor : Removing Jquery from various files #230
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@devartstar @Arnabdaz @Prerna-0202 I have also removed JQuery from the actions.js file pls .review this and suggest the changes if required : ) |
@DhairyaMajmudar Please make one PR per file. Also add a screenshot from netlify preview to ensure that feature is working properly after making the change. |
Sure I will follow up on the same and come up with individual PRs |
@DhairyaMajmudar great, could you please.qke sure that the screenshots are related to the files being changed. Eg when changing loading screen, the screenshot should include loading screen. |
@tachyons I have updated my PR with the relevant screenshots But some prs where having code changes which was either related to some logic, and that logic was used in several other files. As of which I am not able to provide SS proof for those prs. Pls. review the code changes and merge my PRs if it looks good to you. |
Fixes #27
Describe the changes you have made in this PR -
Removal of JQuery code from files
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.