Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Toggle): feat for TabsBar.vue using Pinia Store | #222 #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NayakPenguin
Copy link
Contributor

Fixes #222

Describe the changes you have made in this PR -

1. TabsBar.vue :

  • I incorporated a toggle button in the top-right corner.
  • The toggle functionality is height-based, concealing surplus tabs using overflow.

2. Extra.vue :

  • Calling the state from the Piana store for the simulator which is inside this file.

3. state.ts :

  • Created a boolean state by name SimulatorWasClicked

4. actions.ts :

  • Implemented a function setSimulatorClicked ito update the state's SimulatorWasClicked property with the given boolean value.

Screenshots of the changes (If any) -

Screen.Recording.2023-12-25.at.11.22.26.AM.mov

Few extra minor changes -

Changes are made to make the vue simulator be consistent with the main simulator.

1. Adjusted the tabs bar to a smaller height.

2. Ensured uniform alignment and transformed buttons into squares.

3. Reduced the size of the close button.

Screenshot 2023-12-25 at 12 09 41 PM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 3890488
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/658a827fad32ea000808da9d
😎 Deploy Preview https://deploy-preview-224--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NayakPenguin
Copy link
Contributor Author

@Arnabdaz @Prerna-0202 Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Toggle Feature for the overflowed tabs
1 participant