-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Toggle): bug fixes for TabsBar.vue | #222 #223
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Arnabdaz @Prerna-0202 please review |
@NayakPenguin don't put any javascript in extra.vue try putting the logics in tabsbar.vue |
@Arnabdaz But that way we can't do the second part of objective 4 in issue #222 Reason : I need the information that the circuit space/simulator has been clicked make the height of tabsbar go back to normal. I think if we don't want part II of object 4 then we don't need JS in Extra.vue, and in my opinion Please suggest if there is some other way out. |
Co-authored-by: Arnabdaz <[email protected]>
@Arnabdaz done |
Fixes #222
Describe the changes you have made in this PR -
1. TabsBar.vue :
2. Extra.vue :
3. Toggle effect logic & prop communication between Extra.vue and TabsBar.vue :
Screenshots of the changes (If any) -
Screen.Recording.2023-12-25.at.11.22.26.AM.mov
Few extra minor changes -
Changes are made to make the vue simulator be consistent with the main simulator.
1. Adjusted the tabs bar to a smaller height.
2. Ensured uniform alignment and transformed buttons into squares.
3. Reduced the size of the close button.
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.