Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Toggle): bug fixes for TabsBar.vue | #222 #223

Merged
merged 19 commits into from
Jan 16, 2024

Conversation

NayakPenguin
Copy link
Contributor

Fixes #222

Describe the changes you have made in this PR -

1. TabsBar.vue :

  • I incorporated a toggle button in the top-right corner.
  • The toggle functionality is height-based, concealing surplus tabs using overflow.

2. Extra.vue :

  • Serving as the parent of TabsBar.vue, I introduced a prop to monitor clicks within the simulator space.
  • This prop facilitates toggling the TabsBar back to its default initial height upon a click within the simulator space.

3. Toggle effect logic & prop communication between Extra.vue and TabsBar.vue :

Screenshot 2023-12-25 at 11 58 17 AM Screenshot 2023-12-25 at 11 59 05 AM

Screenshots of the changes (If any) -

Screen.Recording.2023-12-25.at.11.22.26.AM.mov

Few extra minor changes -

Changes are made to make the vue simulator be consistent with the main simulator.

1. Adjusted the tabs bar to a smaller height.

2. Ensured uniform alignment and transformed buttons into squares.

3. Reduced the size of the close button.

Screenshot 2023-12-25 at 12 09 41 PM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit fa1d815
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/65a6ca6b9694710008ecabca
😎 Deploy Preview https://deploy-preview-223--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NayakPenguin
Copy link
Contributor Author

NayakPenguin commented Dec 25, 2023

@Arnabdaz @Prerna-0202 please review

@Arnabdaz
Copy link
Member

@NayakPenguin don't put any javascript in extra.vue try putting the logics in tabsbar.vue

@NayakPenguin
Copy link
Contributor Author

@Arnabdaz But that way we can't do the second part of objective 4 in issue #222 selecting the circuit space portion should revert the tabs to their default state., apart from that everything can be done.

Reason : I need the information that the circuit space/simulator has been clicked make the height of tabsbar go back to normal.

I think if we don't want part II of object 4 then we don't need JS in Extra.vue, and in my opinion selecting the circuit space portion should revert the tabs to their default state is not a imp feature.

Please suggest if there is some other way out.

src/components/Extra.vue Outdated Show resolved Hide resolved
@NayakPenguin
Copy link
Contributor Author

@Arnabdaz done

Arnabdaz

This comment was marked as outdated.

src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
src/components/TabsBar/TabsBar.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Toggle Feature for the overflowed tabs
2 participants