-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Removing console warnings and errors #214
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Prerna-0202 @Arnabdaz pls. review the PR and suggest the changes if needed Thank You : ) |
@Arnabdaz just ping for PR review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DhairyaMajmudar can you fix these issues that come up on building the simulator
Sure @Arnabdaz would be happy to do so : ) |
Also if this pr looks good can you pls. merge it. |
add the changes in this pr itself ... push the changes into the same branch and it would propagate in this pr |
Sure @Arnabdaz I will follow up the same 😃 |
@Arnabdaz I have removed the warning from the console while building the simulator for that I followed the approach
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arnabdaz This unexpected behavior is because of the white color font I think previously because of some error the white text color was not applied and by default black font was styled. cc: @tachyons @devartstar |
This can be fixed by changing |
55c2743
to
466bc64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM cc @tachyons
Fixes #196
Describe the changes you have made in this PR -
import { defineProps, defineEmits } from 'vue'
since its not required any more.color_theme.scss
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.