Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Removing console warnings and errors #214

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar commented Dec 19, 2023

Fixes #196

Describe the changes you have made in this PR -

  • Upgraded the font awesome from V5 to V6 to remove the console errors / warnings
  • Commented the hamburger.css file import causing warnings in the console
  • commented import { defineProps, defineEmits } from 'vue' since its not required any more.
  • Removed JQuery from color_theme.scss
  • Removed js comments from CSS files
  • Removed warning from console while building the simulator

Screenshots of the changes (If any) -

image

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 9e1d1bd
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/659442a66e74100008a47613
😎 Deploy Preview https://deploy-preview-214--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DhairyaMajmudar
Copy link
Contributor Author

@Prerna-0202 @Arnabdaz pls. review the PR and suggest the changes if needed

Thank You : )

@DhairyaMajmudar
Copy link
Contributor Author

@Arnabdaz just ping for PR review

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhairyaMajmudar can you fix these issues that come up on building the simulator
Screenshot from 2023-12-24 16-01-16

@DhairyaMajmudar
Copy link
Contributor Author

Sure @Arnabdaz would be happy to do so : )

@DhairyaMajmudar
Copy link
Contributor Author

Also if this pr looks good can you pls. merge it.

@Arnabdaz
Copy link
Member

add the changes in this pr itself ... push the changes into the same branch and it would propagate in this pr

@DhairyaMajmudar
Copy link
Contributor Author

Sure @Arnabdaz I will follow up the same 😃

@DhairyaMajmudar
Copy link
Contributor Author

DhairyaMajmudar commented Dec 25, 2023

@Arnabdaz I have removed the warning from the console while building the simulator for that I followed the approach

  • Analysed the files from where warnings were coming.
  • Those warning were due to JQuery code present in color_theme.scss file
  • And because of JS comments in .scss files.

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
there seems to be some issues with the css variable changes take a look carefully and verify

@DhairyaMajmudar
Copy link
Contributor Author

DhairyaMajmudar commented Dec 30, 2023

@Arnabdaz This unexpected behavior is because of the white color font (--text-circuit) . But that was already predefined in the file Link to that code

I think previously because of some error the white text color was not applied and by default black font was styled.

cc: @tachyons @devartstar

@DhairyaMajmudar
Copy link
Contributor Author

DhairyaMajmudar commented Dec 30, 2023

This can be fixed by changing --text-circuit to #000 color code.

@DhairyaMajmudar DhairyaMajmudar force-pushed the console branch 4 times, most recently from 55c2743 to 466bc64 Compare January 1, 2024 15:21
Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @tachyons

@Arnabdaz Arnabdaz merged commit 8a606cb into CircuitVerse:main Jan 3, 2024
10 of 11 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the console branch January 4, 2024 14:30
@DhairyaMajmudar DhairyaMajmudar changed the title Removing console warnings and errors Feat: Removing console warnings and errors Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing Console Warnings
3 participants