Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gsoc): navbar revamp #177

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Conversation

Arnabdaz
Copy link
Member

@Arnabdaz Arnabdaz commented Jul 9, 2023

Fixes Revamp Navbar

Describe the changes you have made in this PR -

  • improve navbar options with modern vuejs and vuetify
  • reduce dom manipulation
  • fix all options to work properly
  • improve navbar for mobile devises and improve responsiveness

Screenshots of the changes (If any) -

Screenshot from 2023-07-09 22-53-18
Screenshot from 2023-07-09 22-53-32
Screenshot from 2023-07-09 22-53-53

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Arnabdaz added 30 commits June 18, 2023 01:27
…te, circuit name change, circuit switching, etc issues

Signed-off-by: Arnabdaz <[email protected]>
…th seperate helper vue components and remove watch and setInterval to improve performance

Signed-off-by: Arnabdaz <[email protected]>
…e from simulator, confirm component to replace confirm() and alert()

Signed-off-by: Arnabdaz <[email protected]>
…le entering in the update project form

Signed-off-by: Arnabdaz <[email protected]>
…imeout of 1 second for testing

Signed-off-by: Arnabdaz <[email protected]>
…SaveData being async function

Signed-off-by: Arnabdaz <[email protected]>
@commit-lint
Copy link

commit-lint bot commented Jul 9, 2023

Features

  • gsoc: fix tabbar issue, project loading, updating, circuit delete, circuit name change, circuit switching, etc issues (4cb44fe)
  • netlify: add _redirects to fix routing issues with netlify deployment (7048947)
  • gsoc: update types for store and naming error fixes (da44f65)
  • gsoc: update prompt component structure to make it a common helper component (2b54f90)
  • gsoc: fix cancle on save unify circuit creation and deletion with seperate helper vue components and remove watch and setInterval to improve performance (1ecd749)
  • gsoc: add new project creation, project details update on create from simulator, confirm component to replace confirm() and alert() (8dd0799)
  • gsoc: add import & export as .cv file with independent vue components (c02fd39)
  • gsoc: update updateProjectDetails.vue to show tags as chips while entering in the update project form (48926a5)
  • gsoc: revamp theuser menu in new github style, show user icon and add locale change option (c4bcf0a)
  • gsoc: revamp navbar links part 1 of revamping navbar (37c0379)
  • gsoc: update color on menu list item hover (80dfdfd)
  • gsoc: update setup fucntion and fix linting issues, remove setTimeout of 1 second for testing (e468b15)
  • jwt: add jwt in Authorization header (df9a0bf)
  • gsoc: update hamburger menu with sidebar (7c010ee)

Bug Fixes

  • netlify-build: add / to check netlify build fixes (2966743)
  • netlify: update netlify.toml to get _redirects to correct directory after build (39aa9c6)
  • netlify: move redirects to neltify.toml (39b3bb5)
  • gsoc: quit saving on clicking cancle while entering new proejct name from simualtor (8f2d316)
  • key-binding: call new circuit correctly with the keybinding (959b66e)
  • gsoc: recover project not saving to localStorage due to generateSaveData being async function (dea9ee2)
  • lint: fix linting issues in save.js & remove var from setup.js for const (6047127)
  • linting: data.spec.js remove unused parameter "text" from line 26 (24a032c)
  • lint: fix codeclimate linting issues (b3a3734)
  • lint: fix linting issues (6cbb918)

Update

  • gsoc: convert alert() and confirm() to use vue component (cba9c59)

Contributors

Arnabdaz

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit a62f538
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/65996c166a2fa40008beb78b
😎 Deploy Preview https://deploy-preview-177--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devartstar devartstar added the ux-review waiting to be reviewed by ux maintainers label Sep 5, 2023
@Arnabdaz
Copy link
Member Author

cc @nitin10s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux-review waiting to be reviewed by ux maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants