Upgrade library to Angular 6 #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 3, 2018 12:42
``` ng update @angular/cli ng update @angular/core npm uninstall rxjs-compat ```
``` ng update @angular/cli ng update @angular/core npm update rxjs ```
|
Hi, |
|
Per the PR and the commit descriptions, they are incompatible, and so confusing to retain. So far as I could tell, the upgrade to Angular 6 generates incompatible metadata, per the link in the PR description. |
|
I'll keep the examples but remove the scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking: Upgrades library to Angular 6:
angular.jsonnor other project updates to allow use ofng buildfor library creation, though those updates have been tested in an experimental branch.Motivation: When I thought the best way to resolve issue #376 was to use the Angular 6
@Injectable( { providedIn: 'root'})approach, I upgraded the library to Angular 6. (As it turns out, the Angular 6providerIn: 'root'approach does not work to create a service singleton when the service is provided in a library consumed by an application, only when used directly in an application.)