Feature/refactoring raid java #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new utils you can now use these variable from the config file
fixed NPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm not an active PR user but I wanted to use your bot and then I saw i could touch the code and I love Java..
So first things first, I was in the
EnvVariableclass and saw it was a bit complicated and could lead to errors if, imagine, you got more thanStringin the .env file.Then I decided to make a litle "feature" on a new Utils called
Variables.It is pretty much the same thing as yours, but it now offers the power to add more to a new file called
configuration.properties. It is more common to use these in a Java project than Env variables or files like this. I'm the first to be guilty of using env variable before knowing thePropertiestrickFinally, you will find in the PR, the new Utils
Variables, changes to the codebase using it and a test class, because you want test classes and I'm still training to do them every time I think of it 😄 .Nothing big in term of functionality.
Hope you like and merge it 😉