Release v1.1.4 : Fix onItemSelected call twice when call setSelection…

… inside of thread
Chivorns · Jul 12, 2019 · 6a20fad · 6a20fad
1 parent 0259bc5
commit 6a20fad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -113,7 +113,7 @@ The best Android spinner library for your android application with more customiz
 
 ```gradle
 dependencies {
-    implementation 'com.github.chivorns:smartmaterialspinner:1.1.3'
+    implementation 'com.github.chivorns:smartmaterialspinner:1.1.4'
 }
 ```
 

diff --git a/smartmaterialspinner/build.gradle b/smartmaterialspinner/build.gradle
@@ -5,7 +5,7 @@ ext {
     LIBRARY_NAME = 'SmartMaterialSpinner'
     PUBLISH_GROUP_ID = 'com.github.chivorns'
     PUBLISH_ARTIFACT_ID = LIBRARY_NAME.toLowerCase()
-    PUBLISH_VERSION = '1.1.3'
+    PUBLISH_VERSION = '1.1.4'
 
     // Bintray
     BINTRAY_REPO = 'maven'
@@ -32,7 +32,7 @@ android {
     defaultConfig {
         minSdkVersion 14
         targetSdkVersion 28
-        versionCode 18
+        versionCode 19
         versionName "$PUBLISH_VERSION"
 
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"

diff --git a/...tmaterialspinner/src/main/java/com/chivorn/smartmaterialspinner/SmartMaterialSpinner.java b/...tmaterialspinner/src/main/java/com/chivorn/smartmaterialspinner/SmartMaterialSpinner.java
@@ -794,24 +794,17 @@ public void setSelection(int position) {
         if (isShowing && !isSearchable && hint != null) {
             position -= 1;
         }
-        final int finalPosition = position;
-        this.post(new Runnable() {
-            @Override
-            public void run() {
-                SmartMaterialSpinner.super.setSelection(hint != null ? finalPosition + 1 : finalPosition);
-                checkReSelectable(finalPosition);
-            }
-        });
+        SmartMaterialSpinner.super.setSelection(hint != null ? position + 1 : position);
+        checkReSelectable(position);
     }
 
     @Override
     public void setSelection(int position, boolean animate) {
         if (isShowing && !isSearchable && hint != null) {
             position -= 1;
         }
-        final int finalPosition = position;
-        super.setSelection(hint != null ? finalPosition + 1 : finalPosition, animate);
-        checkReSelectable(finalPosition);
+        super.setSelection(hint != null ? position + 1 : position, animate);
+        checkReSelectable(position);
     }
 
     public void clearSelection() {