-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fusion] @semanticNonNull composition support #7731
Merged
michaelstaib
merged 4 commits into
main-version-15
from
tte/semantic-non-null-fusion-composition
Mar 13, 2025
Merged
[Fusion] @semanticNonNull composition support #7731
michaelstaib
merged 4 commits into
main-version-15
from
tte/semantic-non-null-fusion-composition
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27c3631
to
14c9b73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7731 +/- ##
==========================================
+ Coverage 74.32% 74.34% +0.02%
==========================================
Files 2880 2881 +1
Lines 150293 150397 +104
Branches 17479 17498 +19
==========================================
+ Hits 111709 111820 +111
+ Misses 32767 32758 -9
- Partials 5817 5819 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/HotChocolate/Skimmed/src/Skimmed/BuiltIns/SemanticNonNullDirectiveDefinition.cs
Outdated
Show resolved
Hide resolved
2bd18d4
to
221294b
Compare
221294b
to
b1306dd
Compare
michaelstaib
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Fusion
Issue is related to Hot Chocolate Fusion
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
🌶️ hot chocolate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the composition of semantic non-null with non-null and nullable types.
null
is an expected valuenull
is an expected value