Skip to content

remove list support from convert_atom_to_bytes() #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

remove list support from convert_atom_to_bytes() #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0bcd3
remove `list` support from `convert_atom_to_bytes()`
altendky Dec 7, 2023
50856db
remove associated test
altendky Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions clvm/SExp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def looks_like_clvm_object(o: typing.Any) -> bool:

# this function recognizes some common types and turns them into plain bytes,
def convert_atom_to_bytes(
v: typing.Union[bytes, str, int, None, list],
v: typing.Union[bytes, str, int, None],
) -> bytes:

if isinstance(v, bytes):
Expand All @@ -47,8 +47,6 @@ def convert_atom_to_bytes(
return int_to_bytes(v)
if v is None:
return b""
if v == []:
return b""
if hasattr(v, "__bytes__"):
return bytes(v)

Expand Down
1 change: 0 additions & 1 deletion tests/to_sexp_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ def test_convert_atom(self):

assert convert_atom_to_bytes(b"foobar") == b"foobar"
assert convert_atom_to_bytes(None) == b""
assert convert_atom_to_bytes([]) == b""

assert convert_atom_to_bytes(DummyByteConvertible()) == b"foobar"

Expand Down