Skip to content

Refactor BlockTools #19492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+134 −146
Open

Refactor BlockTools #19492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
754ff62
simplify BlockTools by making include_transactions=True independent f…
arvidn Apr 6, 2025
9852a66
improve error message in validate_coins()
arvidn Apr 7, 2025
80e4314
we don't know if a block will become a transaction block, we we can't…
arvidn Apr 7, 2025
e72c8a2
factor out NewBlockGenerator creation into a function
arvidn Apr 8, 2025
77b59d7
remove unused variable
arvidn Apr 8, 2025
45573a5
use latest version of test-cache
arvidn Apr 9, 2025
f606e56
extend timeout
arvidn Apr 11, 2025
a136537
fix coverage
arvidn Apr 14, 2025
7be621b
extend sync timeout
arvidn Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
python-version: ["3.10"]
env:
CHIA_ROOT: ${{ github.workspace }}/.chia/mainnet
BLOCKS_AND_PLOTS_VERSION: 0.43.0
BLOCKS_AND_PLOTS_VERSION: 0.44.0

steps:
- name: Clean workspace
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-single.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
CHIA_ROOT: ${{ github.workspace }}/.chia/mainnet
CHIA_SIMULATOR_ROOT: ${{ github.workspace }}/.chia/simulator
JOB_FILE_NAME: tests_${{ matrix.os.file_name }}_python-${{ matrix.python.file_name }}_${{ matrix.configuration.module_import_path }}${{ matrix.configuration.file_name_index }}
BLOCKS_AND_PLOTS_VERSION: 0.43.0
BLOCKS_AND_PLOTS_VERSION: 0.44.0

steps:
- name: Configure git
Expand Down
7 changes: 6 additions & 1 deletion chia/_tests/blockchain/test_build_chains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ def validate_coins(constants: ConsensusConstants, blocks: list[FullBlock]) -> No
)

for rem in removals:
unspent_coins.remove(rem)
try:
unspent_coins.remove(rem)
except KeyError: # pragma: no cover
print(f"at height: {block.height} removal: {rem} does not exist")
print("coinset: ", unspent_coins)
raise

for add, _ in additions:
unspent_coins.add(add)
Expand Down
2 changes: 1 addition & 1 deletion chia/_tests/core/full_node/test_full_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2683,7 +2683,7 @@ def check_nodes_in_sync() -> bool:
p2 = full_node_1.full_node.blockchain.get_peak()
return p1 == p2

await time_out_assert(100, check_nodes_in_sync)
await time_out_assert(300, check_nodes_in_sync)
peak = full_node_2.full_node.blockchain.get_peak()
assert peak is not None
print(f"peak: {str(peak.header_hash)[:6]}")
Expand Down
Loading
Loading